Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sg 686 torch compile #1172

Merged
merged 103 commits into from
Jun 28, 2023
Merged

Feature/sg 686 torch compile #1172

merged 103 commits into from
Jun 28, 2023

Conversation

BloodAxe
Copy link
Collaborator

@BloodAxe BloodAxe commented Jun 14, 2023

@BloodAxe BloodAxe marked this pull request as ready for review June 28, 2023 10:31
Louis-Dupont
Louis-Dupont previously approved these changes Jun 28, 2023
Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@BloodAxe
Copy link
Collaborator Author

@Louis-Dupont I've updated the warning message to include version requirement. Unfortunately it dismissed approval state. Can you please re-approve?

Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit 3c2f836 into master Jun 28, 2023
5 checks passed
@BloodAxe BloodAxe deleted the feature/SG-686-torch-compile branch June 28, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants