Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect use of collections.OrderedDict in type annotation #1141

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Fix incorrect use of collections.OrderedDict in type annotation #1141

merged 1 commit into from
Jun 6, 2023

Conversation

BloodAxe
Copy link
Collaborator

@BloodAxe BloodAxe commented Jun 6, 2023

Fixes typo slipped in #1138

shaydeci
shaydeci approved these changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaydeci shaydeci merged commit a3191c4 into master Jun 6, 2023
1 check passed
@shaydeci shaydeci deleted the feature/SG-000-hotfix-typing branch June 6, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaydeci shaydeci shaydeci approved these changes

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

@Louis-Dupont Louis-Dupont Awaiting requested review from Louis-Dupont

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BloodAxe @shaydeci