Bug/sg 000 merge failure for datasetparams #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaydeci
requested review from
ofrimasad,
BloodAxe and
Louis-Dupont
as code owners
BloodAxe
previously approved these changes
Jun 6, 2023
…ilure_for_datasetparams
…asetparams' into bug/SG-000_merge_failure_for_datasetparams
shaydeci
dismissed stale reviews from ofrimasad, Louis-Dupont, and BloodAxe
via
a451d97
…ilure_for_datasetparams # Conflicts: # src/super_gradients/training/utils/checkpoint_utils.py
|
Pls add test to tests/unit_tests/detection_dataset_test.py ^_^ |
Added a simple test that uses dataloaders.get with dataset_params that indclude an entry which is not present in the yaml file (this is what caused the crash). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes in #1092 caused pose estimation recipe tests to crash https://app.circleci.com/pipelines/github/Deci-AI/super-gradients/7748/workflows/5d210255-4bed-4736-b4d4-b693d6bc91e1/jobs/23382
This is becaue there are overrides for dataset params from the command line, causing the merge to fail.
Before calling merge we neeed to set the two configs's struct to false, other wise if one includes an attribute which the other one does not have - the merge will fail.