Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo fix in modify_params_for_qat #1129

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Typo fix in modify_params_for_qat #1129

merged 2 commits into from
Jun 5, 2023

Conversation

shaydeci
Copy link
Collaborator

@shaydeci shaydeci commented Jun 5, 2023

@shaydeci shaydeci marked this pull request as ready for review June 5, 2023 10:58
@shaydeci shaydeci changed the title atypo fixed Typo fix in modify_params_for_qat Jun 5, 2023
BloodAxe
BloodAxe approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaydeci shaydeci merged commit 915bebf into master Jun 5, 2023
1 check passed
@shaydeci shaydeci deleted the bug/SG-000_dataloader_params_typo_for_qat branch June 5, 2023 11:11
@shaydeci shaydeci mentioned this pull request Jun 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BloodAxe BloodAxe BloodAxe approved these changes

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

@Louis-Dupont Louis-Dupont Awaiting requested review from Louis-Dupont

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shaydeci @BloodAxe