Hotfix/alg 1470 drop boxes padding #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurkovak
requested review from
shaydeci,
ofrimasad,
BloodAxe and
Louis-Dupont
as code owners
BloodAxe
reviewed
May 31, 2023
BloodAxe
reviewed
May 31, 2023
|
Thanks for the fast review, addressed |
# Conflicts: # src/super_gradients/recipes/dataset_params/coco_detection_yolo_nas_dataset_params.yaml # src/super_gradients/training/transforms/transforms.py
BloodAxe
reviewed
Jun 5, 2023
# Conflicts: # tests/unit_tests/test_deprecations.py
Louis-Dupont
reviewed
Jun 5, 2023
|
@Louis-Dupont @BloodAxe addressed, please take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed max_targets param from:
DetectionTargetsFormatTransformDetectionPaddedRescale, it didn't do anything anywayDetectionHorizontalFlipfor the case of empty targets, because there won't be a collate to undo itUpdated:
Trained:
(both just to see train/val epoch runs, didn't do metric checks)