Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/sg 000 fix breaking changes in some imports #1101

Merged
merged 3 commits into from
May 30, 2023

Conversation

BloodAxe
Copy link
Collaborator

Fixes imports of BasicBlock from training.models (Happened between 3.0.7 and 3.0.8)

Now, the following imports would work as expected and emit reasonable warnings:

from super_gradients.training.models import BasicBlock, make_divisible

BasicBlock(1, 1, 1)
make_divisible(1, 1)
D:\Develop\GitHub\Deci\super-gradients\b.py:2: DeprecationWarning: You're importing `BasicBlock` class from `super_gradients.training.models`. This is deprecated since SuperGradients 3.1.0.
This block was renamed to BasicResNetBlock for better clarity.
Please update your code to import it as follows:
[-] from super_gradients.training.models import BasicBlock
[+] from super_gradients.training.models import BasicResNetBlock

  BasicBlock(1, 1, 1)
D:\Develop\GitHub\Deci\super-gradients\b.py:4: DeprecationWarning: You're importing `make_divisible` from `super_gradients.training.models`. This is deprecated since SuperGradients 3.1.0.
Please update your code to import it as follows:
[-] from super_gradients.training.models import make_divisible
[+] from super_gradients.training.utils import make_divisible

Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@BloodAxe BloodAxe merged commit 6b5785d into master May 30, 2023
1 check passed
@BloodAxe BloodAxe deleted the hotfix/SG-000-fix-imports branch May 30, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants