Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arch_param deprecated #1084

Merged

Conversation

Louis-Dupont
Copy link
Contributor

No description provided.

shaydeci
shaydeci previously approved these changes May 24, 2023
Copy link
Collaborator

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Is there anywhere else we should apply this decorator @ofrimasad @danbochman ?

@BloodAxe
Copy link
Collaborator

I think we really need to add some tests to ensure it is working as expected and not cause any side-effects. I will add these

@BloodAxe
Copy link
Collaborator

Added some tests to ensure we covered all edge cases. And improved warning text with more clear message and direct action points to fix the issue:

[2023-05-25 13:50:00] WARNING - utils.py - The CustomizableDetector.__init__ received `arch_params` argument which is deprecated and will be removed in next versions. Please change the signature of the __init__ method to take explicit list arguments instead: CustomizableDetector.__init__(backbone, heads, neck, bn_eps, bn_momentum, inplace_act, in_channels)

[2023-05-25 13:50:01] WARNING - utils.py - The CustomizableDetector.__init__ received `arch_params` argument which is deprecated and will be removed in next versions. Please change the signature of the __init__ method to take explicit list arguments instead: CustomizableDetector.__init__(backbone, heads, neck, num_classes, bn_eps, bn_momentum, inplace_act, in_channels)

[2023-05-25 13:50:01] WARNING - utils.py - The DummyModelV2.__init__ received `arch_params` argument which is deprecated and will be removed in next versions. Please change the signature of the __init__ method to take explicit list arguments instead: DummyModelV2.__init__(backbone, head, neck)

BloodAxe
BloodAxe previously approved these changes May 25, 2023
@BloodAxe BloodAxe dismissed stale reviews from shaydeci and themself via 5e25574 May 25, 2023 11:52
@ofrimasad ofrimasad merged commit a3618e8 into master May 28, 2023
1 check passed
@ofrimasad ofrimasad deleted the hotfix/SG-000-deprecated_arch_params_in_some_classes branch May 28, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants