Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YoloNAS benchmarking tutorial #1076

Merged
merged 12 commits into from
May 28, 2023
Merged

YoloNAS benchmarking tutorial #1076

merged 12 commits into from
May 28, 2023

Conversation

shaydeci
Copy link
Collaborator

No description provided.

@shaydeci shaydeci changed the title tutorial finalized YoloNAS benchmarking tutorial May 24, 2023
@shaydeci shaydeci marked this pull request as ready for review May 24, 2023 12:33
NatanBagrov
NatanBagrov reviewed May 24, 2023
View reviewed changes
Copy link
Contributor

@NatanBagrov NatanBagrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

documentation/source/BenchmarkingYoloNAS.md Outdated Show resolved Hide resolved
documentation/source/BenchmarkingYoloNAS.md Outdated Show resolved Hide resolved
documentation/source/BenchmarkingYoloNAS.md Outdated Show resolved Hide resolved
documentation/source/BenchmarkingYoloNAS.md Outdated Show resolved Hide resolved
documentation/source/BenchmarkingYoloNAS.md Outdated Show resolved Hide resolved
ofrimasad
ofrimasad reviewed May 24, 2023
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my comment inline

documentation/source/BenchmarkingYoloNAS.md Outdated Show resolved Hide resolved
documentation/source/BenchmarkingYoloNAS.md Outdated Show resolved Hide resolved
documentation/source/BenchmarkingYoloNAS.md Outdated Show resolved Hide resolved
documentation/source/BenchmarkingYoloNAS.md Outdated Show resolved Hide resolved
Louis-Dupont
Louis-Dupont reviewed May 24, 2023
View reviewed changes
Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the content is clear but there are some links/format to be fixed.
Also added some comments on the display but these are just notes/ideas.
One thing that we should do is to add this to mkdocs.yaml so that this would be displayed on the documentation website.

documentation/source/BenchmarkingYoloNAS.md Outdated Show resolved Hide resolved
documentation/source/BenchmarkingYoloNAS.md Outdated Show resolved Hide resolved
documentation/source/BenchmarkingYoloNAS.md Show resolved Hide resolved
documentation/source/BenchmarkingYoloNAS.md Outdated Show resolved Hide resolved
documentation/source/BenchmarkingYoloNAS.md Outdated Show resolved Hide resolved
documentation/source/BenchmarkingYoloNAS.md Outdated Show resolved Hide resolved
documentation/source/BenchmarkingYoloNAS.md Outdated Show resolved Hide resolved
documentation/source/BenchmarkingYoloNAS.md Outdated Show resolved Hide resolved
documentation/source/BenchmarkingYoloNAS.md Outdated Show resolved Hide resolved
Louis-Dupont
Louis-Dupont reviewed May 24, 2023
View reviewed changes
Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the content is clear but there are some links/format to be fixed.
Also added some comments on the display but these are just notes/ideas.
One thing that we should do is to add this to mkdocs.yaml so that this would be displayed on the documentation website.

@BloodAxe
Copy link
Collaborator

BloodAxe commented May 24, 2023 •
edited
Loading

@shaydeci great improvement, aside small typos - LGTM
Do we want to include short TLDR section at the start of tutorial:

Getting 10FPS for YoloNAS on your 4090 and feeling cheated? Read this carefully

@shaydeci
Copy link
Collaborator Author

@shaydeci great improvement, aside small typos - LGTM Do we want to include short TLDR section at the start of tutorial:

Getting 10FPS for YoloNAS on your 4090 and feeling cheated? Read this carefully

Hehe sure!

ofrimasad
ofrimasad reviewed May 28, 2023
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small typos

documentation/source/BenchmarkingYoloNAS.md Outdated Show resolved Hide resolved
ofrimasad
ofrimasad approved these changes May 28, 2023
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrimasad ofrimasad merged commit fefdfd3 into master May 28, 2023
1 check passed
@ofrimasad ofrimasad deleted the feature/SG-865_benchmarking_yolonas_guide branch May 28, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BloodAxe BloodAxe BloodAxe left review comments

@NatanBagrov NatanBagrov NatanBagrov left review comments

@Louis-Dupont Louis-Dupont Louis-Dupont left review comments

@ofrimasad ofrimasad ofrimasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shaydeci @BloodAxe @ofrimasad @NatanBagrov @Louis-Dupont