Skip to content

Commit

Permalink
Added instructions what to do when PR contains unsigned commits (#1486)
Browse files Browse the repository at this point in the history
  • Loading branch information
BloodAxe committed Sep 27, 2023
1 parent 15c0fe1 commit c6f92fd
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,23 @@ $ git config --global gpg.program /usr/local/bin/gpg
$ git config --global commit.gpgsign true
```

### I have created PR with unsigned commits. Do I have to start over?

No. What you need to do is create another branch starting from master, then move your commits from PR branch to the
new branch and force push it to the remote under the old name. Let's say your PR branch named 'feature/my_awesome_pr'
then you need to do the following:

```bash
git checkout master
git checkout -b feature/my_awesome_pr_signed
git merge --squash --no-commit feature/my_awesome_pr
git commit -S -m "My signed commit"
git push -f origin feature/my_awesome_pr_signed:feature/my_awesome_pr
```

Last command will overwrite your PR branch with the new signed commit containing all changes from the PR.

```bash

## Jupyter Notebooks Contribution

Expand Down

0 comments on commit c6f92fd

Please sign in to comment.