Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocean: finishing get/list loan token api #2968

Conversation

canonbrother
Copy link
Contributor

@canonbrother canonbrother commented Jul 9, 2024

Summary

  • add active_price and fixed_interval_price_id on struct LoanToken
  • sorted by creation_tx

Checked

list
    ✕ should listLoanTokens (10 ms) - undefined typing
    ✓ should listLoanTokens with pagination (4 ms)
    ✓ should listLoanTokens with an empty object if size 100 next 300 which is out of range (1 ms)
  get
    ✕ should get loan token by symbol (2 ms) - undefined typing
    ✕ should throw error while getting non-existent loan token id (10 ms) - errmsg

@canonbrother canonbrother self-assigned this Jul 9, 2024
@canonbrother canonbrother force-pushed the canonbrother/ocean-api-vault branch 2 times, most recently from cd240c5 to 7b01322 Compare July 16, 2024 02:53
@canonbrother canonbrother force-pushed the canonbrother/ocean-api-list-get-loan-token-active-price-fixed-interval-price-id branch from d1f3098 to 9c14ffa Compare July 16, 2024 03:00
@canonbrother canonbrother force-pushed the canonbrother/ocean-api-list-get-loan-token-active-price-fixed-interval-price-id branch from 9c14ffa to df4d671 Compare July 16, 2024 06:11
@canonbrother canonbrother force-pushed the canonbrother/ocean-api-list-get-loan-token-active-price-fixed-interval-price-id branch from 4f54917 to 441b68c Compare July 16, 2024 09:18
Base automatically changed from canonbrother/ocean-api-vault to feature/ocean-archive July 16, 2024 09:32
@canonbrother canonbrother force-pushed the canonbrother/ocean-api-list-get-loan-token-active-price-fixed-interval-price-id branch from 441b68c to efe2727 Compare July 16, 2024 09:35
@canonbrother canonbrother marked this pull request as ready for review July 16, 2024 09:39
@canonbrother canonbrother requested a review from Jouzo July 16, 2024 09:39
@Jouzo Jouzo merged commit 53835b1 into feature/ocean-archive Jul 16, 2024
3 of 4 checks passed
@Jouzo Jouzo deleted the canonbrother/ocean-api-list-get-loan-token-active-price-fixed-interval-price-id branch July 16, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants