Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ocean: list auctions api #2942

Merged
merged 8 commits into from
Jul 16, 2024
Merged

Ocean: list auctions api #2942

merged 8 commits into from
Jul 16, 2024
+381 −136

Conversation

canonbrother
Copy link
Contributor

@canonbrother canonbrother commented Jun 18, 2024 •
edited
Loading

Summary

  • list_auctions api
  • refactor set_loan_token indexer (todo: index_block_end)

test coverage

list
    ✓ should listAuctions (26 ms)
    ✓ should listAuctions with pagination (8 ms)
    ✓ should listAuctions with an empty object if out of range (1 ms)

Blocked 🚫 by
DeFiCh/rust-defichain-rpc#6
DeFiCh/rust-defichain-rpc#10

@canonbrother canonbrother force-pushed the canonbrother/ocean-api-list-auctions branch 6 times, most recently from eb9583e to bdbb1ac Compare June 19, 2024 08:32
@canonbrother canonbrother force-pushed the canonbrother/ocean-api-list-auctions branch from bdbb1ac to 259e146 Compare July 1, 2024 09:17
@canonbrother canonbrother self-assigned this Jul 2, 2024
@canonbrother canonbrother requested a review from Jouzo July 16, 2024 02:48
@canonbrother canonbrother marked this pull request as ready for review July 16, 2024 02:49
@canonbrother canonbrother force-pushed the canonbrother/ocean-api-list-auctions branch 3 times, most recently from 5123d90 to 14d69a7 Compare July 16, 2024 05:31
@canonbrother canonbrother force-pushed the canonbrother/ocean-api-list-auctions branch 2 times, most recently from 4c851e7 to 821ca97 Compare July 16, 2024 05:38
@canonbrother canonbrother marked this pull request as draft July 16, 2024 05:39
@canonbrother canonbrother marked this pull request as ready for review July 16, 2024 05:48
@Jouzo Jouzo merged commit 4186f2b into feature/ocean-archive Jul 16, 2024
3 of 4 checks passed
@Jouzo Jouzo deleted the canonbrother/ocean-api-list-auctions branch July 16, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jouzo Jouzo Awaiting requested review from Jouzo

Assignees

@canonbrother canonbrother

Labels
b/ocean
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@canonbrother @Jouzo