feat: human focus transfer domain

[canonbrother]

Summary

Requirement

transferdomain <from> <to> <amount> <domain=auto> <domain-specific-opts...> (eg: change-addr=from-for-utxo)

Simplifiy transfer domain command line form

from

transferdomain [{"src":{"address":src,"amount":"1@DFI","domain":3},"dst":{"address":dst,"amount":"1@DFI","domain": 2}}]

to

transferdomain src dst tokenAmount(eg: 1@DFI) domain(0 - auto, 1 - utxo, 2 - dvm, 3 - evm) nonce(optional)
transferdomain src dst tokenAmount domain(eg: 1@DFI) nonce(optional)

RPCs

• transferdomain

[Jouzo]

transferdomain src dst tokenAmount(eg: 1@DFI) nonce(optional)

Are we inferring the domains ?

[canonbrother]

transferdomain src dst tokenAmount(eg: 1@DFI) nonce(optional)

Are we inferring the domains ?

was removed.. as just found out the domain can be justified via to automatically..
eg: if to == erc55 then domain = evm

[Jouzo]

Shouldn't we add an additional optional domain to be future proof, i.e. for when we add support to UTXO ?

[canonbrother]

Shouldn't we add an additional optional domain to be future proof, i.e. for when we add support to UTXO ?

hmm.. yea.. finishing up the basic first.. now impl the utox stuff 😬

[prasannavl]

Help params need to be outside of the if branch and with both help messages in the same unit.
Only the final Check call inside.

[canonbrother]

not sure i'm doing it correctly
refined 9e23c23

[canonbrother]

custom made RPCHelpMan 480b080

transferdomain
Creates (and submits to local node and network) a tx to transfer assets across domains. DVM to EVM/EVM to DVM, etc.

Arguments:
1. array | string                       (json array | string, required) A json array of src and dst json objects
    [
    {                        (json object)
        "src": {               (json object) Source arguments
        "address": "str",    (string, required) Source address
        "amount": "str",     (string, required) Amount transfered, the value is amount in amount@token format
        "domain": n,         (numeric, required) Domain of source: 2 - DVM, 3 - EVM
        },
        "dst": {               (json object) Destination arguments
        "address": "str",    (string, required) Destination address
        "amount": "str",     (string, required) Amount transfered, the value is amount in amount@token format
        "domain": n,         (numeric, required) Domain of source: 2 - DVM, 3 - EVM
        },
        "nonce": n,            (numeric) Optional parameter to specify the transaction nonce
    },
    ...
    ]
   from                         (string, required) the source address of sender
2. to                           (string, required) the destination address of sender
3. tokenAmount                  (string, required) in amount@token format
4. nonce

Result:
"hash"                  (string) The hex-encoded hash of broadcasted transaction

Examples:
> defi-cli transferdomain '[{"src":{"address":"<DFI_address>", "amount":"1.0@DFI", "domain": 2}, "dst":{"address":"<ETH_address>", "amount":"1.0@DFI", "domain": 3}}]'
> defi-cli transferdomain '[{"src":{"address":"<ETH_address>", "amount":"1.0@DFI", "domain": 3}, "dst":{"address":"<DFI_address>", "amount":"1.0@DFI", "domain": 2}}]'
> defi-cli transferdomain "from" "to" "100@DFI"
> defi-cli transferdomain "from", "to", 100@BTC 2"

[canonbrother]

removed utxo support
checkpoint at 9e0c557
prefix at src/dst if needed since utxo is not supported

[canonbrother]

⚠️ On hold PR.. transferdomain not working due to RPCHelpMan arg checks.. will check again