New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no_discard attribute to critical methods #2256

Closed

prasannavl wants to merge 20 commits into master from pvl/no-discard

Member

prasannavl commented Jul 29, 2023

Summary

Enforce better error handling

Implications

Storage
- Database reindex required
- Database reindex optional
- Database reindex not required
- None
Consensus
- Network upgrade required
- Includes backward compatible changes
- Includes consensus workarounds
- Includes consensus refactors
- None

prasannavl and others added 8 commits

July 29, 2023 12:34


          Handle the errors properly

5ae95de


          Add NODISCARD to critical methods

53a7501


          Merge branch 'master' into pvl/no-discard

388ab71


          Revert changes to processevmqueue

9cdf048


          Add no discard to sub with remainder methods

eb41e20


          Fix no discard warnings

d2bc8fb


          Add nodiscard to CBalance struct

bc5f53f


          Remove nodiscard on balances, fixes to rpc accounts

dbc45f4

Member

sieniven commented Aug 1, 2023

Reverted error handling on ProcessEVMQueue since the fixes are inside #2263


          Better refactor

91ae6c8

sieniven previously approved these changes

View reviewed changes

prasannavl commented

View reviewed changes

src/masternodes/balances.h Outdated Show resolved Hide resolved

prasannavl commented

View reviewed changes

src/masternodes/balances.h Outdated Show resolved Hide resolved

prasannavl commented

View reviewed changes

src/masternodes/balances.h Outdated Show resolved Hide resolved

prasannavl commented

View reviewed changes

src/masternodes/mn_checks.cpp Outdated Show resolved Hide resolved

prasannavl commented

View reviewed changes

src/masternodes/mn_checks.cpp Outdated Show resolved Hide resolved


          Fixes to remove Require usage

8c0d1c6

sieniven dismissed their stale review via

8c0d1c6

August 1, 2023 06:38


          Fix to require usage

acd858f

sieniven self-requested a review

August 1, 2023 06:40

sieniven previously approved these changes

View reviewed changes


          Switch away from nodiscard macro

b39f237

sieniven dismissed their stale review via

b39f237

August 2, 2023 16:29

prasannavl and others added 7 commits

August 3, 2023 10:50


          Merge branch 'master' into pvl/no-discard

7a2b089


          Merge branch 'master' into pvl/no-discard

e995369


          Merge branch 'master' into pvl/no-discard

2a50e38


          Add res to nodiscard methods

0ea9125


          Fix lint

0cc97af


          Merge branch 'master' into pvl/no-discard

4d6dbed


          Merge branch 'master' into pvl/no-discard

edb134b


          Merge branch 'master' into pvl/no-discard

1df52b0

Member Author

prasannavl commented Jul 15, 2024

Closing outdated PRs

prasannavl closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet