Add custom reward address to createmasternode RPC
#1941
Closed
+95
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shohamc1
suggested changes
Apr 27, 2023
Bushstar
reviewed
May 9, 2023
prasannavl
changed the title
createmasternode
prasannavl
changed the title
createmasternode createmasternode RPC
Bushstar
reviewed
Jun 15, 2023
src/masternodes/mn_checks.cpp
Outdated
| @@ -820,6 +820,10 @@ class CCustomTxApplyVisitor : public CCustomTxVisitor { | |||
| node.creationHeight = height; | |||
| node.operatorType = obj.operatorType; | |||
| node.operatorAuthAddress = obj.operatorAuthAddress; | |||
| if (height >= static_cast<uint32_t>(consensus.NextNetworkUpgradeHeight)) { | |||
| node.rewardAddressType = obj.rewardType; | |||
There was a problem hiding this comment.
In CMasternodesView::CreateMasternode add checks that the type is either NoDestType, PKHashType, ScriptHashType or WitV0KeyHashType, so 0, 1, 2 or 4.
Bushstar
reviewed
Jun 15, 2023
src/masternodes/rpc_masternodes.cpp
Outdated
| @@ -165,7 +174,12 @@ UniValue createmasternode(const JSONRPCRequest& request) | |||
| throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Address (%s) is not owned by the wallet", EncodeDestination(ownerDest))); | |||
| } | |||
|
|
|||
| if (rewardDest.index() != 1 && rewardDest.index() != 4) { | |||
There was a problem hiding this comment.
Remove this check and let it happen on the consensus side. Reward will include type 2 as well on the next hard fork due to PR 1664.
Bushstar
reviewed
Jun 15, 2023
src/masternodes/rpc_masternodes.cpp
Outdated
| @@ -133,15 +134,23 @@ UniValue createmasternode(const JSONRPCRequest& request) | |||
|
|
|||
| std::string ownerAddress = request.params[0].getValStr(); | |||
| std::string operatorAddress = request.params.size() > 1 && !request.params[1].getValStr().empty() ? request.params[1].getValStr() : ownerAddress; | |||
| std::string rewardAddress = !request.params[4].getValStr().empty() ? request.params[4].getValStr() : ownerAddress; | |||
There was a problem hiding this comment.
Leave empty if no reward is set, so just get an empty string here, dest will be 0 which is the toggle as to whether to use the reward address or not.
prasannavl
added
the
up-for-grab
blocs0
approved these changes
Oct 13, 2023
|
Closing stale PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created to fix this issue. It will allow the user to create a masternode while specifying a custom reward address.
RPCs