Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erosita cleaning bug fix #286

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Erosita cleaning bug fix #286

merged 5 commits into from
Jul 29, 2024

Conversation

jessicapilling
Copy link
Collaborator

@jessicapilling jessicapilling commented Jul 24, 2024

This addresses issue #285 . The FLAGSEL keyword was being written incorrectly when the user was selecting a flag/ flag_invert parameter.

Within this branch is a function that could be used to write this FLAGSEL keyword, if we ever get all the definitions of the different flag bits that eSASS uses, but until then, this function is useless.

This should be tested before being merged into main! Apologies I havent had the chance to yet!

@DavidT3 DavidT3 self-assigned this Jul 24, 2024
@DavidT3 DavidT3 self-requested a review July 24, 2024 16:10
Copy link
Owner

@DavidT3 DavidT3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just address those two aesthetic comments I made and feel free to merge into main - I don't think we need to test this (famous last words), it should just work

daxa/process/erosita/assemble.py Outdated Show resolved Hide resolved
daxa/process/erosita/assemble.py Outdated Show resolved Hide resolved
@jessicapilling jessicapilling merged commit 875acdd into master Jul 29, 2024
@jessicapilling jessicapilling deleted the erositaCleaningBugFix branch July 29, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants