Unit tests/mission classes #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
March 28, 2024 15:56
jessicapilling
commented
May 1, 2024
DavidT3
requested changes
May 1, 2024
There was a problem hiding this comment.
Again good job on getting so many tests done - this is great.
My main concern is the general lack of comments in the tests - you don't have to explain every little thing (particularly in the cases where they're essentially copy pasted across different missions), but a little context would be good (maybe think in terms of someone else who might want to add to the tests after you, what would help them get a handle on what is going on)
added 6 commits
May 1, 2024 17:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of the unit tests are in test_erosita.py.
Other test_{telescope}.py files are all just making sure properties are returning the correct values.
I found some small bugs while testing that are also fixed in this branch.