Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split ArrowField derive macro #88

Merged
merged 4 commits into from
Jan 3, 2023

Conversation

jondo2010
Copy link
Contributor

This PR splits the ArrowField derive macro into separate macros for each derived trait.

Why: the previous undocumented container attributes to control which traits get implemented is not flexible enough. This way users have complete control over which trait gets generated.

@ncpenke
Copy link
Collaborator

ncpenke commented Jan 3, 2023

Thanks for the change, please let me know if you need help fixing any of the CI.

@jondo2010
Copy link
Contributor Author

Looks like CI hasn't run in a few months. I fixed everything here I think, which should also fix #89 if we land that after.

@ncpenke
Copy link
Collaborator

ncpenke commented Jan 3, 2023

Thanks for fixing. main hasn't had changes since November, which is why CI hasn't run. We shifted development to a feature branch which requires rust 1.65 features. I'll rebase those changes on top of yours.

@ncpenke
Copy link
Collaborator

ncpenke commented Jan 3, 2023

Looks like tests still failing, please let me know if you need help.

@jondo2010
Copy link
Contributor Author

I guess we should bump the version as well since this is breaking :)

@codecov-commenter
Copy link

Codecov Report

Merging #88 (a339e8a) into main (6c37e29) will increase coverage by 2.94%.
The diff coverage is 98.66%.

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   95.31%   98.25%   +2.94%     
==========================================
  Files           8        8              
  Lines        1450     1490      +40     
==========================================
+ Hits         1382     1464      +82     
+ Misses         68       26      -42     
Impacted Files Coverage Δ
arrow2_convert/src/lib.rs 100.00% <ø> (ø)
arrow2_convert_derive/src/input.rs 86.50% <66.66%> (+17.82%) ⬆️
arrow2_convert_derive/src/lib.rs 87.50% <88.88%> (ø)
arrow2_convert_derive/src/derive_enum.rs 99.03% <98.46%> (+0.51%) ⬆️
arrow2_convert_derive/src/derive_struct.rs 99.74% <99.69%> (+0.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants