Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Utf8Scalar #106

Closed
wants to merge 1 commit into from

Conversation

emilk
Copy link
Contributor

@emilk emilk commented Mar 8, 2023

Closes #105

@codecov-commenter
Copy link

Codecov Report

Merging #106 (39eb555) into main (b2fd8f8) will increase coverage by 0.08%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   94.63%   94.71%   +0.08%     
==========================================
  Files           8        8              
  Lines        1565     1589      +24     
==========================================
+ Hits         1481     1505      +24     
  Misses         84       84              
Impacted Files Coverage Δ
arrow2_convert/src/deserialize.rs 100.00% <100.00%> (ø)
arrow2_convert/src/field.rs 100.00% <100.00%> (ø)
arrow2_convert/src/serialize.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ncpenke
Copy link
Collaborator

ncpenke commented Mar 18, 2023

The change looks overall. One question, so that I understand and can document the use-case of this better, when is it preferable to use Utf8Scalar vs String?

@emilk
Copy link
Contributor Author

emilk commented Mar 19, 2023

I was about to write that Utf8Scalar has O(1) cloning and slicing, but reading the docs now that isn't the case at all 😬

I assumed it did because Buffer does, but I was a bit hasty in my assumptions. I'll need to rethink this a bit 😅

@emilk emilk closed this Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ArrowSerialize/ArrowDeserialize for Utf8Scalar
3 participants