Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setuptools to dependencies #412

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

xopham
Copy link
Contributor

@xopham xopham commented Jul 10, 2024

I believe guarddog technically depends on setuptools though that is installed in most cases.
To test this:

  1. Run a python container: docker run -it python /bin/bash
  2. Create an environment with bare dependencies
cd /home
pip install poetry
python -m venv venv --without-pip
. venv/bin/activate
poetry init --quiet
poetry add guarddog
deactivate
  1. Activate virtual environment and convince yourself that you are running guarddog in venv
guarddog  # fails because we are not in the venv
. venv/bin/activate
which guarddog
guarddog
  1. guarddog fails with lack of pkg_resources

That said, it might be possible to reduce installed part of setuptools as is done in pip

@sobregosodd sobregosodd merged commit 4110327 into main Jul 10, 2024
10 checks passed
@sobregosodd sobregosodd deleted the christoph.hamsen/add-setuptools-dependency branch July 10, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants