Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use strict version constraints in pyproject.toml #245

Merged
merged 4 commits into from
Jun 21, 2023
Merged

Do not use strict version constraints in pyproject.toml #245

merged 4 commits into from
Jun 21, 2023

Conversation

AngellusMortis
Copy link
Contributor

Fixes #79

@AngellusMortis AngellusMortis changed the title feature: Do not use strict version constraints in pyproject.toml Do not use strict version constraints in pyproject.toml Jun 15, 2023
@AngellusMortis
Copy link
Contributor Author

AngellusMortis commented Jun 15, 2023 •
edited
Loading

I also updated the requirements.txt using poetry export which seems to be the way you are suppose to do it. I do not know if you guys were updating it before. I also do not really have any experience with poetry either.

@AngellusMortis AngellusMortis mentioned this pull request Jun 15, 2023
Merged
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 19, 2023
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GuardDog-pypi found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@christophetd
Copy link
Contributor

Thanks for the contribution, looks like the CI is failing though. Let me know if you need help fixing it

@christophetd christophetd merged commit 2118695 into DataDog:main Jun 21, 2023
9 checks passed
@AngellusMortis AngellusMortis deleted the feature/no-restrict branch June 21, 2023 17:18
@AngellusMortis
Copy link
Contributor Author

Is there a change we can get a new PyPi release now? It looks like there has not been one since March and there has been a number of new changes (outside of just this one).

@christophetd
Copy link
Contributor

I was hoping to merge a few more PRs before a release, but since it has taken more time than anticipated, no objection - thanks for the nudge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophetd christophetd christophetd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid using strict version constraints in pyproject.yaml
2 participants
@AngellusMortis @christophetd