-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create tests to evaluate the number of false positives and false negatives #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romain-dd
force-pushed
the
rma/test_false_positives
branch
3 times, most recently
from
April 17, 2023 07:36
ebfcb02
to
4deb421
Compare
romain-dd
force-pushed
the
rma/test_false_positives
branch
from
April 28, 2023 11:22
d5bb91b
to
cc7047a
Compare
romain-dd
force-pushed
the
rma/test_false_positives
branch
2 times, most recently
from
April 28, 2023 12:03
0f4758c
to
cf2bd19
Compare
christophetd
reviewed
May 1, 2023
christophetd
reviewed
May 1, 2023
christophetd
reviewed
May 1, 2023
christophetd
reviewed
May 1, 2023
christophetd
reviewed
May 1, 2023
christophetd
reviewed
May 1, 2023
christophetd
reviewed
May 2, 2023
christophetd
reviewed
May 2, 2023
romain-dd
force-pushed
the
rma/test_false_positives
branch
from
May 5, 2023 11:01
82e50a7
to
28013b4
Compare
christophetd
reviewed
May 8, 2023
romain-dd
force-pushed
the
rma/test_false_positives
branch
from
May 9, 2023 10:28
7d668bf
to
0dda770
Compare
christophetd
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is done in this PR:
"result": {"npm-install-script": {}, "steganography": {}}
. So we''ll only get the categories if something malicious/suspicious has been found, if nothing found, we'll get"result": {}
Test round 1:
100
legit packages, it took ~5min (which is too slow), and found 12 false positivesTest round 2: