Make sure spans are closed when processing notifications #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelchcki
changed the title
pawelchcki
changed the title
pawelchcki
added
bug
delner
reviewed
Jul 9, 2018
| @@ -73,18 +70,21 @@ | |||
| parent = tracer.trace('parent_span') | |||
| expect(subject.parent_id).to eq parent.span_id | |||
| end | |||
|
|
|||
| it 'sets span in payload' do | |||
| expect { subject }.to change { payload[:datadog_span] }.to be_instance_of(Datadog::Span) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In multithreaded setup and when using connection pool while performing many SQL queries, the
active_spanin finishing of event was not always the same to span created at the start of an event.This caused some odd spans to not properly close - leaking memory in the process. Benchmark application memory use did baloon 2-4x in a matter of minutes
This PR addresses this issue.
Its possible it might one of the causes of #431, as this regression was introduced in 0.12.0 and affects multithreaded apps - i.e. Sidekiq.
Todo: