Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract #ensure_clean_context! from ActiveSupport::Notifications subscription #390

Merged

Conversation

delner
Copy link
Contributor

@delner delner commented Apr 3, 2018

When we extracted Datadog::Contrib::ActiveSupport::Notifications::Subscription from our Racecar integration, we migrated a ensure_clean_context! method along with it. This was in error; this method is specific to Racecar, and is causing side-effects for other subscription based integrations.

This pull request removes ensure_clean_context! from the subscription, and replaces it with before_trace/after_trace callbacks. Racecar then uses this new set of callbacks to re-implement ensure_clean_context! in its own patcher.

Should unblock #340.

@delner delner added bug Involves a bug integrations Involves tracing integrations labels Apr 3, 2018
@delner delner self-assigned this Apr 3, 2018
@delner delner force-pushed the bugfix/active_support_notifications_ensure_clean_context branch from 09c355b to c65431b Compare April 3, 2018 20:01
@delner delner added this to the 0.12.0 milestone Apr 4, 2018
@palazzem palazzem merged commit 9dfc349 into 0.12-dev Apr 5, 2018
@delner delner deleted the bugfix/active_support_notifications_ensure_clean_context branch May 8, 2018 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Involves a bug integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants