-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frozen string literals #3392
Merged
Merged
Frozen string literals #3392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
appsec
Application Security monitoring product
core
Involves Datadog core libraries
integrations
Involves tracing integrations
profiling
Involves Datadog profiling
tracing
labels
Jan 22, 2024
TonyCTHsu
force-pushed
the
tonycthsu/frozen-strings
branch
from
January 22, 2024 15:56
49d43d4
to
43fd327
Compare
ekump
reviewed
Jan 30, 2024
TonyCTHsu
force-pushed
the
tonycthsu/frozen-strings
branch
from
January 30, 2024 19:44
ab4449d
to
a320982
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.0 #3392 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 1249 1249
Lines 72086 72079 -7
Branches 3372 3372
=======================================
- Hits 70741 70736 -5
+ Misses 1345 1343 -2 ☔ View full report in Codecov by Sentry. |
marcotc
approved these changes
Feb 1, 2024
This was referenced Apr 12, 2024
This was referenced Apr 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0 Upgrade Guide notes
🚨 In 2.0, all the strings are frozen. Make sure your code does not mutate them.