-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add the Monkey as a deprecated module #336
Conversation
|
||
def setup | ||
@buf = StringIO.new | ||
Datadog::Tracer.log = Datadog::Logger.new(@buf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go as the CI is green. Let's:
- merge this one on
master
- ship a new 0.11.2 release on top of this branch
e606d52
to
5ffcd94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already released in the current 0.11.2 release so it's safe to be merged in the current master.
#322 removed
Datadog::Monkey
with version 0.11.1.To address some backwards compatibility issues, this pull request reintroduces the
Datadog::Monkey
API, but as a deprecated module that does nothing. Instead it prints deprecation warnings to the logs, advising users to upgrade their implementation.This module will be removed again in future versions. Users should upgrade to the new configuration API before then:
https://github.com/DataDog/dd-trace-rb/releases/tag/v0.11.0