-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for Rails 3 #3324
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.0 #3324 +/- ##
==========================================
+ Coverage 97.99% 98.06% +0.06%
==========================================
Files 1246 1243 -3
Lines 71960 71873 -87
Branches 3401 3388 -13
==========================================
- Hits 70520 70481 -39
+ Misses 1440 1392 -48 ☔ View full report in Codecov by Sentry. |
45a4c61
to
2c6e2f9
Compare
@@ -1,6 +1,5 @@ | |||
Component,Origin,License,Copyright | |||
lib/datadog/core/vendor/multipart-post,https://github.com/socketry/multipart-post,MIT,"Copyright (c) 2007-2013 Nick Sieger." | |||
lib/datadog/tracing/contrib/active_record/vendor,https://github.com/rails/rails/,MIT,"Copyright (c) 2005-2018 David Heinemeier Hansson" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this an automated process, or did you know you had to manually remove this license?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just kind of remembered it, I think it was luck.
Not sure if it's worth creating a GH Action for such detection.
2c6e2f9
to
4684459
Compare
2.0 Upgrade Guide notes
Support for Rails 3 has been removed.
Motivation:
Rails 3's last release is from 2016. It support requires custom code relative to newer versions of Rails.
Additional Notes:
How to test the change?
There are integration tests covering the Rails integration.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!