Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case-insensitive propagation style configuration #3299

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Dec 1, 2023

2.0 Upgrade Guide notes
The the values for the environment variables DD_TRACE_PROPAGATION_STYLE, DD_TRACE_PROPAGATION_STYLE_INJECT, and DD_TRACE_PROPAGATION_STYLE_EXTRACT are now considered case-insensitive.
The major impact of this change is that, previously, B3 would configure Tracing with the B3 Multiple Headers propagator. Now B3 will configure it with the B3 Single Header propagator.

Motivation:

This change aligns the Ruby tracer with all other Datadog Tracers.

Additional Notes:

How to test the change?

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@marcotc marcotc requested review from a team as code owners December 1, 2023 01:21
@marcotc marcotc self-assigned this Dec 1, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ef2354) 97.99% compared to head (d4b1d76) 97.99%.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           remove-old-style-envs    #3299      +/-   ##
=========================================================
- Coverage                  97.99%   97.99%   -0.01%     
=========================================================
  Files                       1248     1248              
  Lines                      72011    72028      +17     
  Branches                    3392     3392              
=========================================================
+ Hits                       70570    70586      +16     
- Misses                      1441     1442       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from remove-old-style-envs to 2.0 December 5, 2023 20:46
@marcotc marcotc merged commit 9df7a53 into 2.0 Dec 5, 2023
152 checks passed
@marcotc marcotc deleted the case-insensitive-styles branch December 5, 2023 20:46
@TonyCTHsu TonyCTHsu added this to the 2.0 milestone Feb 20, 2024
@ivoanjo ivoanjo added the 2.0 label Mar 14, 2024
@TonyCTHsu TonyCTHsu modified the milestones: 2.0, 2.0.0.beta1 Mar 22, 2024
@TonyCTHsu TonyCTHsu mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants