Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated B3 configuration style #3294

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Remove deprecated B3 configuration style #3294

merged 1 commit into from
Dec 5, 2023

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Nov 30, 2023

2.0 Upgrade Guide notes

The deprecated B3 and B3 single header propagation style configuration values have been removed, use b3multi and b3 respectively instead.

What does this PR do?

Motivation:

The new values now align with OpenTelemetry propagation style names.

Additional Notes:

How to test the change?

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@marcotc marcotc requested a review from a team as a code owner November 30, 2023 22:21
@marcotc marcotc self-assigned this Nov 30, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b46fe7) 97.99% compared to head (ed7d516) 97.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.0    #3294   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files        1248     1248           
  Lines       72058    72031   -27     
  Branches     3401     3392    -9     
=======================================
- Hits        70616    70590   -26     
+ Misses       1442     1441    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcotc marcotc merged commit 80c5e47 into 2.0 Dec 5, 2023
151 checks passed
@marcotc marcotc deleted the remove-old-b3 branch December 5, 2023 20:46
@TonyCTHsu TonyCTHsu added this to the 2.0 milestone Feb 20, 2024
@ivoanjo ivoanjo added the 2.0 label Mar 14, 2024
@TonyCTHsu TonyCTHsu modified the milestones: 2.0, 2.0.0.beta1 Mar 22, 2024
@TonyCTHsu TonyCTHsu mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants