[PROF-8632] Ruby heap size profiling PoC #3261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoanjo
reviewed
Nov 16, 2023
Comment on lines
+204
to
+210
| if (heap_recorder->enable_heap_size_profiling) { | ||
| // To get an accurate object size, we need to query our tracked live objects so lets iterate over the object_records | ||
| st_foreach(heap_recorder->object_records, st_object_records_iterate, (st_data_t) &internal_iteration_data); | ||
| } else { | ||
| // If we're just reporting heap counts/samples, it's faster to iterate on the heap records | ||
| st_foreach(heap_recorder->heap_records, st_heap_records_iterate, (st_data_t) &internal_iteration_data); | ||
| } |
There was a problem hiding this comment.
Uh, this is interesting -- may be worth calling out as an intro comment in the design of the heap recorder at some point.
Comment on lines
336
to
+343
| ENFORCE_BOOLEAN(cpu_time_enabled); | ||
| ENFORCE_BOOLEAN(alloc_samples_enabled); | ||
| ENFORCE_BOOLEAN(heap_samples_enabled); | ||
|
|
||
| struct stack_recorder_state *state; | ||
| TypedData_Get_Struct(recorder_instance, struct stack_recorder_state, &stack_recorder_typed_data, state); | ||
|
|
||
| state->heap_recorder = heap_recorder_init(); | ||
| state->heap_recorder = heap_recorder_init(heap_size_enabled == Qtrue); |
There was a problem hiding this comment.
Minor: Don't forget the ENFORCE_BOOLEAN, to avoid typing accidents ;)
Also, perhaps we should raise if heap_samples_enabled == false but heap_size_enabled == true
2 tasks
AlexJF
force-pushed
the
alexjf/prof-8543-ruby-heap-profiling-poc
branch
from
2a11d34
to
564543c
Compare
|
Replaced with more production-ready versions starting from #3281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Build on top of #3246 by adding a new profile type capturing the weighted heap size of all live sampled objects in the heap.
Motivation:
Tracking the number of living objects alone does not give us an idea of resource (in this case, memory) utilisation. To understand how close we are to hitting limits and OOMing, we need to understand the cumulative size of things in heap.
Additional Notes:
How to test the change?
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!