Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add out.host and out.port to Elasticsearch #288

Merged
merged 1 commit into from
Dec 22, 2017
Merged

Add out.host and out.port to Elasticsearch #288

merged 1 commit into from
Dec 22, 2017

Conversation

delner
Copy link
Contributor

@delner delner commented Dec 21, 2017

This pull request adds the out.host and out.port tags to traces for Elasticsearch.

@delner delner self-assigned this Dec 21, 2017
@delner delner force-pushed the delner/add_elasticsearch_host_and_port branch from a8f82cc to 8253211 Compare December 21, 2017 20:23
p-lambert
p-lambert reviewed Dec 21, 2017
View reviewed changes
Copy link
Member

@p-lambert p-lambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! @delner did you check if transport.connections[0].host is provided by all supported versions?

@delner
Copy link
Contributor Author

delner commented Dec 21, 2017

Yeah, looks like it does, back to 1.x.

p-lambert
p-lambert approved these changes Dec 21, 2017
View reviewed changes
Copy link
Member

@p-lambert p-lambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@delner great! thanks!

@delner delner merged commit 58e1643 into master Dec 22, 2017
@palazzem palazzem added this to the 0.11.0 milestone Jan 17, 2018
@delner delner deleted the delner/add_elasticsearch_host_and_port branch February 9, 2018 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-lambert p-lambert p-lambert approved these changes

@palazzem palazzem Awaiting requested review from palazzem

Assignees

@delner delner

Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@delner @p-lambert @palazzem