Fix dalli instrumentation encoding issue
#267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-lambert
force-pushed
the
pedro/dalli-encoding-fix
branch
from
78d898b
to
968d804
Compare
p-lambert
force-pushed
the
pedro/dalli-encoding-fix
branch
from
968d804
to
943cbfe
Compare
palazzem
approved these changes
Dec 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
memcachedis frequently used to store marshaled objects and other blob types, the Ruby VM might interpretdallirequest arguments as strings with incompatible encodings. This PR adds a safe-guard for that case.