[core] add SyncWriter
#252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palazzem
suggested changes
Nov 21, 2017
lib/ddtrace/sync_writer.rb
Outdated
| proc { flush_trace(trace) } | ||
| ) | ||
| rescue => e | ||
| Tracer.log.error(e) |
There was a problem hiding this comment.
We can check if the regular writer has the same logging level
|
|
||
| # Create SyncWriter instance before forking | ||
| sync_writer = Datadog::SyncWriter.new(transport: pin.tracer.writer.transport) | ||
| Datadog::SyncWriter::CACHED_INSTANCE = sync_writer |
There was a problem hiding this comment.
maybe we can move CACHED_INSTANCE under the Resque namespace instead of the SyncWriter
palazzem
reviewed
Nov 23, 2017
| @@ -3,6 +3,11 @@ module Contrib | |||
| module Resque | |||
| SERVICE = 'resque'.freeze | |||
|
|
|||
| class << self | |||
| # Globally-acccesible reference for pre-forking optimization | |||
p-lambert
force-pushed
the
pedro/add-sync-writer
branch
from
149d802
to
cfd17b5
Compare
p-lambert
force-pushed
the
pedro/add-sync-writer
branch
from
cfd17b5
to
81ec98a
Compare
palazzem
approved these changes
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a sync writer so that no threads are used to flush data. This means that when the
Tracerfinishes a trace (calling thewrite()method under the hood), the call is blocking. It's not meant to be used as a default tracer, but instead a good replacement in processes that forks and dies at the end (i.e. Resque).It reduces a lot the overhead since no signals / timeouts must be waited.