Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[redis] Updates Redis integration tag/metric #216

Merged
merged 2 commits into from
Oct 16, 2017
Merged

[redis] Updates Redis integration tag/metric #216

merged 2 commits into from
Oct 16, 2017

Conversation

ryplo
Copy link
Contributor

@ryplo ryplo commented Oct 5, 2017 •
edited
Loading

Overview

Addition of redis.raw_command tag and redis.pipeline_length metric.

Rachel Lo added 2 commits October 5, 2017 11:20
Adds .swp to gitignore
8294b9c
[redis] Updates redis tags and metrics to better match python version
0c1b56d 
* Makes commands all capitalized
* Adds raw command tag
* Adds pipeline length metric
* Updates tests
@ryplo ryplo force-pushed the rachel/improve-redis-commands-in-span branch from 0cde582 to 0c1b56d Compare October 5, 2017 21:03
@ryplo ryplo requested a review from palazzem October 5, 2017 21:29
@palazzem palazzem added enhancement integrations Involves tracing integrations labels Oct 5, 2017
@palazzem palazzem added this to the 0.9.1 milestone Oct 6, 2017
palazzem
palazzem approved these changes Oct 16, 2017
View reviewed changes
Copy link
Contributor

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @ryplo ! going to merge that one!

@palazzem palazzem merged commit a662829 into master Oct 16, 2017
@palazzem palazzem deleted the rachel/improve-redis-commands-in-span branch October 16, 2017 12:10
@palazzem palazzem modified the milestones: 0.9.1, 0.10.0 Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palazzem palazzem palazzem approved these changes

Assignees
No one assigned
Labels
integrations Involves tracing integrations
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ryplo @palazzem