Add Datadog::Error value-object
#181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-lambert
force-pushed
the
pedro/fix-error-handling
branch
8 times, most recently
from
390caff
to
46a6790
Compare
palazzem
reviewed
Aug 29, 2017
There was a problem hiding this comment.
Only one question otherwise it seems good to me. Also I found an issue with a Sinatra test:
1) Failure:
TracerTest#test_error [/home/ubuntu/dd-trace-rb/test/contrib/sinatra/tracer_test.rb:99]:
Expected: 1
Actual: 0
Can you take a look? In the meantime I launched again the CI to be sure it's not a flaky test (but probably it isn't).
Thank you for spotting this issue!
| @@ -108,7 +108,7 @@ class TracingControllerTest < ActionController::TestCase | |||
| assert_equal(1, span.status, 'span should be flagged as an error') | |||
| assert_equal('ZeroDivisionError', span.get_tag('error.type'), 'type should contain the class name of the error') | |||
| assert_equal('divided by 0', span.get_tag('error.msg'), 'msg should state we tried to divided by 0') | |||
| assert_nil(span.get_tag('error.stack')) | |||
| assert_empty(span.get_tag('error.stack')) | |||
There was a problem hiding this comment.
why it has been changed? assert_nil ensures that get_tag() returns nil. assert_empty does the same? because we must not have the error.stack set, otherwise if we have (for instance) "", it ends in sending wrong data.
p-lambert
force-pushed
the
pedro/fix-error-handling
branch
4 times, most recently
from
b138116
to
51ff1c3
Compare
p-lambert
force-pushed
the
pedro/fix-error-handling
branch
from
51ff1c3
to
b153e71
Compare
palazzem
approved these changes
Aug 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures all error-related data is properly encoded.