Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rails] introduced DISABLE_DATADOG_RAILS env var to skip Rails magic #173

Merged
merged 5 commits into from
Aug 9, 2017
Merged

[rails] introduced DISABLE_DATADOG_RAILS env var to skip Rails magic #173

merged 5 commits into from
Aug 9, 2017

Conversation

ufoot
Copy link
Member

@ufoot ufoot commented Aug 9, 2017

Follow-up to #156

@ufoot ufoot added this to the 0.8.1 milestone Aug 9, 2017
@ufoot ufoot requested a review from palazzem August 9, 2017 09:10
palazzem
palazzem reviewed Aug 9, 2017
View reviewed changes
docs/GettingStarted.md Outdated
Or, shell syntax, before launching Rails:

```
export DISABLE_DATADOG_RAILS = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export DISABLE_DATADOG_RAILS=1 otherwise is a bad assignment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/o\ of course...

palazzem
palazzem approved these changes Aug 9, 2017
View reviewed changes
Copy link
Contributor

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge when the CI is green!

@ufoot ufoot merged commit fffcc89 into master Aug 9, 2017
@ufoot ufoot mentioned this pull request Aug 9, 2017
Closed
@palazzem palazzem deleted the christian/norailsmagic branch October 6, 2017 18:00
@delner delner mentioned this pull request Sep 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palazzem palazzem palazzem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ufoot @palazzem