[contrib:rails] only treat 5xx errors as real errors #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ufoot
force-pushed
the
christian/errorhandling
branch
from
9909581
to
87dc938
Compare
ufoot
force-pushed
the
christian/errorhandling
branch
from
c29e283
to
12cdddb
Compare
palazzem
approved these changes
Jul 24, 2017
| span.set_tag(Datadog::Ext::Errors::TYPE, error[0]) | ||
| span.set_tag(Datadog::Ext::Errors::MSG, error[1]) | ||
| span.set_tag(Datadog::Ext::Errors::STACK, caller().join("\n")) | ||
| if defined?(::ActionDispatch::ExceptionWrapper) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentionned in #103 -> do not pull the red flag when error is not a
5xxstatus code.