[tracer] limit span and trace IDs to 63 bits #161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One note here: I changed the
MAX_ID
to be2**63
and not2**63 -1
because most of the code using it needs the upper "excluded" limit. Eg,rand(2)
returns 0 or 1, never 2. Also, we use operator%
and it's the same -> to get something between 0 and MAX_ID, including MAX_ID, you'd don % (MAX_ID+1)
. Globally, code is simpler when MAX_ID is just plain2**63
without the- 1
.