Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidekiq w/ ActiveJob reports wrong resource. #90

Closed
tpendragon opened this issue Mar 14, 2017 · 2 comments · Fixed by #94
Closed

Sidekiq w/ ActiveJob reports wrong resource. #90

tpendragon opened this issue Mar 14, 2017 · 2 comments · Fixed by #94
Milestone
0.6.0

Comments

@tpendragon
Copy link

tpendragon commented Mar 14, 2017 •
edited
Loading

All my Sidekiq metrics are reporting the resource as ActiveJob::QueueAdapters::SidekiqAdapter::JobWrapper.
@tpendragon tpendragon changed the title Sidekiq w/ ActiveJob reports wrong class. Sidekiq w/ ActiveJob reports wrong resource. Mar 14, 2017
@tpendragon
Copy link
Author

This should be pretty straight-forward to fix, just need to check for the 'wrapped' option in the job arguments: https://github.com/rails/rails/blob/master/activejob/lib/active_job/queue_adapters/sidekiq_adapter.rb#L22

@ufoot ufoot added this to the 0.6.0 milestone Mar 22, 2017
ufoot added a commit that referenced this issue Mar 22, 2017
@ufoot
[contrib:sidekiq] fixing #90 by extracting wrapper info
87c22e7
@ufoot ufoot mentioned this issue Mar 23, 2017
Merged
@ufoot
Copy link
Member

ufoot commented Mar 23, 2017

FYI @tpendragon I applied the patch you suggested, and it works well. Will very likely ship in our next stable release (coming soon). See #94 for details.

ufoot added a commit that referenced this issue Mar 23, 2017
@ufoot
[contrib:sidekiq] fixing #90 by extracting wrapper info
3309bfa
ufoot added a commit that referenced this issue Mar 24, 2017
@ufoot
[contrib:sidekiq] fixing #90 by extracting wrapper info
f382bc9
@ufoot ufoot closed this as completed in #94 Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

[contrib:sidekiq] handle wrapped ActiveJob resource DataDog/dd-trace-rb
2 participants
@tpendragon @ufoot