Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: fix divergent changes #2879

Draft
wants to merge 7 commits into
base: v2-dev
Choose a base branch
from
Draft

v2: fix divergent changes #2879

wants to merge 7 commits into from

Conversation

hannahkm
Copy link
Contributor

What does this PR do?

This PR addresses divergences that arose from creating v2 of dd-trace-go. It aims to maintain the behavior of v1 as closely as possible, address linting (such as clarifying comments, removing miscellaneous log statements, and removing unused code), and otherwise cleaning up the v2 code.

Motivation

Maintaining v2 while v1 is still active can introduce diverging changes, which we should address before release.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Sep 18, 2024
@pr-commenter
Copy link

pr-commenter bot commented Sep 18, 2024

Benchmarks

Benchmark execution time: 2024-09-19 20:32:41

Comparing candidate commit 485f5d8 in PR branch hannah/divergences with baseline commit 7d4b68c in branch v2-dev.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 0 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant