appsec: Suspicious Attacker Blocking #2878
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2024-09-18 19:43:09 Comparing candidate commit 8f88b8d in PR branch Found 2 performance improvements and 8 performance regressions! Performance is the same for 49 metrics, 0 unstable metrics. scenario:BenchmarkExtractW3C-24
scenario:BenchmarkInjectW3C-24
scenario:BenchmarkPartialFlushing/Disabled-24
scenario:BenchmarkPartialFlushing/Enabled-24
scenario:BenchmarkSingleSpanRetention/no-rules-24
scenario:BenchmarkSingleSpanRetention/with-rules/match-all-24
scenario:BenchmarkSingleSpanRetention/with-rules/match-half-24
scenario:BenchmarkStartSpan-24
scenario:BenchmarkTracerAddSpans-24
|
An error occurred while trying to automatically change base from
eliott.bouhana/APPSEC-54945
to
main
September 18, 2024 14:38
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
eliottness
force-pushed
the
eliott.bouhana/APPSEC-54194
branch
from
cebd010
to
b183600
Compare
* After recieving the order to stop appsec via RC we did not reset the ruleset to the default one * some code in http listeners where deduplicated for RASP SSRF making SSRF RASP span tags not working * its 'exclusions' but its 'exclusion_data' without an 's' Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
eliottness
force-pushed
the
eliott.bouhana/APPSEC-54194
branch
from
b183600
to
8f88b8d
Compare
| @@ -199,6 +199,10 @@ func (a *appsec) stop() { | |||
| a.wafHandle.Close() | |||
| a.wafHandle = nil | |||
| } | |||
|
|
|||
| // Reset rules edits received from the remote configuration | |||
| a.cfg.RulesManager, _ = config.NewRulesManager(nil) | |||
There was a problem hiding this comment.
IIRC, Christophe has added start and stop system tests which you can probably use to further validate this.
There was a problem hiding this comment.
I already enabled them yes
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
rules_databehaviour toexclusion_datato support exclusion listswaf.RunAddressData.Scopeto RASP SSRF WAF rungithub.com/DataDog/datadog-agent/pkg/remoteconfig/stateReviewer's Checklist
Unsure? Have a question? Request a review!