Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: feat(contrib): migrate all pending contribs #2829

Conversation

darccio
Copy link
Contributor

@darccio darccio commented Aug 27, 2024

What does this PR do?

Migrates a subset of the contribs to use the new contrib API. Each commit is a contrib, to simplify code review.

Motivation

Contrib API was created to split contribs as nested modules: see #2768

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio darccio requested review from a team as code owners August 27, 2024 09:42
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Aug 27, 2024
@darccio darccio merged commit fcf8440 into dario.castane/contrib-api-v2 Aug 27, 2024
31 of 156 checks passed
@darccio darccio deleted the dario.castane/porting-contribs-to-contrib-api-3 branch August 27, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant