Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcrypt: disable tests #29475

Closed
wants to merge 1 commit into from
Closed

Conversation

chouquette
Copy link
Contributor

What does this PR do?

Disable building gcrypt tests

Motivation

We don't need to waste resources building those as we'll never run them

This was initially meant to fix the build with a custom toolchain, but the error was somewhere.
It doesn't hurt not to build things we don't need though.

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

We don't need to waste resources building those as we'll never run them
@chouquette chouquette added changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-delivery labels Sep 20, 2024
@chouquette chouquette requested a review from a team as a code owner September 20, 2024 20:39
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 44839746 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@pr-commenter
Copy link

pr-commenter bot commented Sep 20, 2024

Regression Detector

Regression Detector Results

Run ID: 21b16ee6-d71c-4206-bb10-d1b478cbb353 Metrics dashboard Target profiles

Baseline: 4673873
Comparison: f40a535

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +0.33 [-0.41, +1.08] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.19 [+0.14, +0.23] 1 Logs
idle memory utilization +0.02 [-0.03, +0.07] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.08, +0.09] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
basic_py_check % cpu utilization -0.13 [-2.83, +2.57] 1 Logs
otel_to_otel_logs ingress throughput -0.35 [-1.17, +0.46] 1 Logs
file_tree memory utilization -0.44 [-0.54, -0.33] 1 Logs
pycheck_lots_of_tags % cpu utilization -0.78 [-3.30, +1.75] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@chouquette
Copy link
Contributor Author

Hpmf I forgot that this required makeinfo to be available, so it will require a new build image, which will happen in the main custom toolchain PR. I'll close this and will keep the commit in the main PR (#28262)

@chouquette chouquette closed this Sep 20, 2024
@chouquette chouquette deleted the chouquette/dont_build_gcrypt_tests branch September 20, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants