Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variant search config. #995

Merged
merged 31 commits into from
Sep 13, 2024
Merged

Variant search config. #995

merged 31 commits into from
Sep 13, 2024

Conversation

marikomedlock
Copy link
Collaborator

@marikomedlock marikomedlock commented Sep 10, 2024 •
edited
Loading

First pass at variant search config for AoU 2023 Q3R2 CT underlay.

As part of this PR, I also ran indexing on the variant entity and variantPerson entity group on AoU CT test data in the Verily dev project.

marikomedlock and others added 22 commits September 4, 2024 15:05
@marikomedlock
Attribute isRepeated flag. ValidateDataTypes indexing job.
32a2656
@marikomedlock
CreateEntityMainn indexing job.
eb79192
@marikomedlock
Merge branch 'main' into mm-repeated-data-type
8fe09c8
@marikomedlock
WriteEntityLevelDisplayHints indexing job.
5d54178
@marikomedlock
WriteTextSearchField indexing job.
d4b6921
@marikomedlock
Select repeated attr field. Result parsing test list query.
519f3cd
@marikomedlock
Fetch string-only hints. Result parsing test hint query.
c209b0f
@marikomedlock
Merge branch 'main' into mm-repeated-data-type
0620795
@marikomedlock
Group by repeated attribute field. Sql building and results parsing t…
0714da8 
…ests count query.
@marikomedlock
Filter on repeated attribute field. Sql building test list query.
dd3f527
@marikomedlock
Only use FLATTENED alias for repeated attribute field.
4e8c32c
@marikomedlock
OpenAPI repeated type in ValueDisplay. Bug in returning hint query re…
3e4bce0 
…sults.
@marikomedlock
Remove variant config files.
1ae4e10
@marikomedlock
Regenerate docs.
8eb84dc
@marikomedlock
Check actual data rows in result parsing hint & count query tests.
66b6633
@marikomedlock
Merge branch 'main' into mm-repeated-data-type
ea8dff6
@marikomedlock
Fix overlapping conditional in eldh indexing job.
3a5b7e9
@marikomedlock
Variant search config -- first pass.
13625e5
@marikomedlock
Use t_item_count in criteria selector.
0ccd0d8
@marikomedlock
Put back rest of underlay.
4c8413f
@dexamundsen
Merge branch 'main' into mm-repeated-data-type
7f8f84d
@marikomedlock
Add multi-select for variant entity.
6411878
tjennison-work
tjennison-work reviewed Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@tjennison-work tjennison-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to surveys, we won't want to use the existing entity group config/data protos, so if they're not anxious to check this in we might want to wait until we have new ones.

@marikomedlock
Copy link
Collaborator Author

Similar to surveys, we won't want to use the existing entity group config/data protos, so if they're not anxious to check this in we might want to wait until we have new ones.

Yeah, these files will definitely change as we work through future UI & backend changes. I don't have a preference whether we merge now or later, but wanted to leave some working config before I'm out. I'll leave this PR unmerged and you guys can take it over whenever you're ready.

@marikomedlock
Copy link
Collaborator Author

Per offline discussion, moved config files into separate _testonly directories, so we can iterate on these config files across multiple PRs without modifying the underlays that AoU is currently using.

Base automatically changed from mm-repeated-data-type to main September 13, 2024 12:52
@marikomedlock marikomedlock merged commit 3b9ed7a into main Sep 13, 2024
8 checks passed
@marikomedlock marikomedlock deleted the mm-variant-search-config branch September 13, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjennison-work tjennison-work tjennison-work approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marikomedlock @tjennison-work @dexamundsen