Refactor dao classes to extract param build, row insert #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dexamundsen
commented
Sep 12, 2024
•
dexamundsen
commented
- Will help reuse them in clone cohort
- also contains changes from PR comments : Util to generateId, remove extra userEmail args #999
dexamundsen
commented
Sep 12, 2024
| .addValue("enum", enumValue); | ||
| } | ||
|
|
||
| MapSqlParameterSource buildValueParam( |
There was a problem hiding this comment.
made them package private to be callable from other dao classes
dexamundsen
commented
Sep 12, 2024
| .addValue("data_type", annotationKey.getDataType().name()); | ||
| int rowsAffected = jdbcTemplate.update(sql, params); | ||
| LOGGER.debug("CREATE annotation key rowsAffected = {}", rowsAffected); | ||
| MapSqlParameterSource keyParamSets = |
There was a problem hiding this comment.
general pattern: build param, then insert rows
dexamundsen
changed the title
dexamundsen
commented
Sep 14, 2024
| @@ -64,7 +64,7 @@ jobs: | |||
| env: | |||
| TEST_PROJECT_SA_KEY: ${{ secrets.TEST_PROJECT_SA_KEY }} | |||
| - name: Gradle Run Regression Tests Only | |||
| run: ./gradlew service:regressionTests -PregressionTestUnderlays=cmssynpuf,aouSR2019q4r4 --scan | |||
| run: ./gradlew service:regressionTests -PregressionTestUnderlays=cmssynpuf,aouSR2019q4r4 --info --scan | |||
There was a problem hiding this comment.
A comparison of without - https://github.com/DataBiosphere/tanagra/actions/runs/10859538266/job/30139008330#step:8:1
and with -
https://github.com/DataBiosphere/tanagra/actions/runs/10857889854/job/30135081427#step:8:1
For now keeping it out since all of the extra logs are less about the application tests etc and more about the gradle build process, which is not needed regularly.
keeping logs concide really helps with debugging
# Conflicts: # service/src/main/java/bio/terra/tanagra/db/CohortDao.java
tjennison-work
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.