Add ExitCode to the "Exited" message #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarthSim
reviewed
Mar 11, 2024
start/process.go
Outdated
| @@ -209,3 +210,14 @@ func (p *process) respawn() { | |||
| p.waitPid() | |||
| p.output.WriteBoldLinef(p, "Restarted with pid %v...", p.pid) | |||
| } | |||
|
|
|||
| func (p *process) reportExitCode() { | |||
| exitCode := p.tmux.ExitCode() | |||
There was a problem hiding this comment.
tmuxClient.ExitCode() returns the maximum exit code among all panes. It's not applicable here
Envek
reviewed
Mar 12, 2024
start/process.go
Outdated
Comment on lines
216
to
220
| message := "Exited" | ||
|
|
||
| if exitCode != 0 { | ||
| message = fmt.Sprintf("Exited with code %d", exitCode) | ||
| } |
There was a problem hiding this comment.
Does it hurt to always print exit code?
Suggested change
| message := "Exited" | |
| if exitCode != 0 { | |
| message = fmt.Sprintf("Exited with code %d", exitCode) | |
| } | |
| message := fmt.Sprintf("Exited with code %d", exitCode) |
prog-supdex
force-pushed
the
exited_with_code
branch
from
694a90c
to
2477f27
Compare
prog-supdex
force-pushed
the
exited_with_code
branch
from
8ec4ba1
to
adbc082
Compare
prog-supdex
force-pushed
the
exited_with_code
branch
from
5f262e5
to
1392b7c
Compare
DarthSim
approved these changes
Mar 13, 2024
|
Thanks!! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #169
Add the Exit code to the "Exited"