Allow specifying 'all' for process auto restarts

[dunkmann00]

This closes #153

I ended up going with the suggestion for specifying that all processes should auto restart by passing in all, i.e. overmind start -r all rather than adding another flag that is specifically for auto restarting all, i.e. overmind start --auto-restart-all. I thought this was slightly more intuitive, especially since this is how setting formation is already handled.

Let me know what you think!

[dunkmann00]

Hey @DarthSim! If you have a chance could you look this over? Thanks!

[catpreneur]

@dunkmann00 Thanks for this pr!

Look at line 96

overmind/start/command.go

Line 96 in 7d97057

(h.AnyCanDie || utils.StringsContain(canDie, e.OrigName)),

They use a boolean to indicate all can die, not all string. Maybe you should make it a boolean so it's consistent.

[dunkmann00]

Thanks @oofdog! Like I said in my initial comment of this PR, after seeing the suggestion in #153, I thought using all made more sense.

Just to add some more detail -
There is precedent for this in Overmind. Setting the number of instances of a process (formation) uses all as well.

From the Readme:

There is a special name all that you can use to scale all processes at once:

$ overmind start -m all=2,worker=5
$ OVERMIND_FORMATION=all=2,worker=5 overmind start

IMHO, I think changing can-die to support all (or any if preferable) would be better for consistency and simplicity.

P.S. Here is where formation is handled in the code:

overmind/start/procfile.go

Lines 43 to 48 in 7d97057

	num := 1
	if fnum, ok := formation[name]; ok {
	num = fnum
	} else if fnum, ok := formation["all"]; ok {
	num = fnum
	}

[dunkmann00]

Hey @DarthSim! Just wanted to reach out again and see if this PR looks good to you. Thanks!

[Envek]

It is elegant! @mrexox, wdyt?

[mrexox]

@Envek , agree!

[dunkmann00]

Thanks!