fix update image registry and repository

Signed-off-by: KubeKyrie <shaolong.qin@daocloud.io>
DaoCloud · Apr 26, 2024 · 167e039 · 167e039
1 parent 2b4af0c
commit 167e039
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/internal/chart/chart.go b/internal/chart/chart.go
@@ -18,11 +18,16 @@ var (
 
 // updateValuesFile performs some substitutions to a given values.yaml file.
 func updateValuesFile(valuesFile string, targetRepo *api.Target) error {
-	if err := updateContainerImageRegistry(valuesFile, targetRepo); err != nil {
-		return errors.Annotatef(err, "error updating %s file", valuesFile)
+	if targetRepo.ContainerRegistry != "" {
+		if err := updateContainerImageRegistry(valuesFile, targetRepo); err != nil {
+			return errors.Annotatef(err, "error updating %s file", valuesFile)
+		}
 	}
-	if err := updateContainerImageRepository(valuesFile, targetRepo); err != nil {
-		return errors.Annotatef(err, "error updating %s file", valuesFile)
+
+	if targetRepo.ContainerRepository != "" {
+		if err := updateContainerImageRepository(valuesFile, targetRepo); err != nil {
+			return errors.Annotatef(err, "error updating %s file", valuesFile)
+		}
 	}
 	return nil
 }