Fixed Pedestal Subtraction #4
Merged
+62
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the initial pedestal to 14-bit max to avoid the initial garbage TPs.
aeoranday
requested review from
alessandrothea,
glehmannmiotto and
roland-sipos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a new pedestal subtraction processor that estimates the pedestal and fixes it. The period for estimation is configurable with
start_periodand counts the number of time samples before fixing the pedestal (512 ns / tick).I've also squashed a bug in
AVXFrugalPedestalSubtractProcessor.cppthat resulted in a never-decreasing pedestal estimate and solves a problem we were seeing in the TP rates.To avoid the initial garbage TPs, I've also set the starting pedestal value to the 14-bit max. The first TPs will still be nonsensical, but they will start popping up at a more controlled rate. A delayed TP sending can be implemented in
fdreadoutlibsto fully control these bad TPs.This was tested on a test session and reviewing the resulting TPs' ADC peak.
Related PRs
DUNE-DAQ/appmodel#123