Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent call loadData when editing #789

Merged
merged 2 commits into from
Aug 25, 2022
Merged

fix: prevent call loadData when editing #789

merged 2 commits into from
Aug 25, 2022

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 修复当编辑状态下仍触发 loadData 的问题
  • 优化 Input 的样式

@mortalYoung mortalYoung added the bug Something isn't working label Aug 25, 2022
@mortalYoung mortalYoung self-assigned this Aug 25, 2022
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Base: 91.04% // Head: 91.04% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a09ef3e) compared to base (b207f9e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #789   +/-   ##
=======================================
  Coverage   91.04%   91.04%           
=======================================
  Files         180      180           
  Lines        5786     5787    +1     
  Branches     1402     1402           
=======================================
+ Hits         5268     5269    +1     
  Misses        512      512           
  Partials        6        6           
Impacted Files Coverage Δ
src/workbench/sidebar/explore/folderTree.tsx 97.70% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mortalYoung mortalYoung mentioned this pull request Aug 25, 2022
7 tasks
Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 80d99bc into main Aug 25, 2022
@wewoor wewoor deleted the fix/input branch August 25, 2022 10:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants