Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Nextjs version 10.2.3 -> 11.0.1 #318

Merged
merged 1 commit into from
Aug 2, 2021
Merged

upgrade Nextjs version 10.2.3 -> 11.0.1 #318

merged 1 commit into from
Aug 2, 2021

Conversation

will0684
Copy link
Member

@will0684 will0684 commented Aug 2, 2021

Description

NOTE: Please use npm version 7 or higher and install with npm i --legacy-peer-deps

A bug in Nextjs versions before Nextjs 11 would crash the application if a user's accept-language-header was not "accepted" by Nextjs. Lookin at the logs, this has happened a couple times already in prod.

{ 
  "time": "2021-08-01T09:31:06.864976381Z", 
  "resourceId": "",
  "operationName": "Microsoft.Web/sites/log",
  "category": "AppServiceConsoleLogs",
  "resultDescription": " Error: Invalid accept-language header\n\n",
  "level": "Error",
  "EventStampType": "Stamp",
  "EventPrimaryStampName": "waws-prod-yt1-035",
  "EventStampName": "waws-prod-yt1-035",
  "Host": "",
  "EventIpAddress": ""
}

You can read about it in this issue here:

vercel/next.js#22329

The fix for this is now part of Nextjs 11.0.1 and this PR bumps us to that version.

There should be no breaking changes with other parts of the application as per the version 10 -> 11 upgrade guide.

Product and Sprint Backlog

Trello

@will0684 will0684 requested a review from a team August 2, 2021 17:52
@github-actions
Copy link

github-actions bot commented Aug 2, 2021

Storybooks Link For Branch
https://dts-stn.github.io/Alpha-Site/refs/pull/318/merge

@github-actions
Copy link

github-actions bot commented Aug 2, 2021

Copy link
Contributor

@EphraimAssi EphraimAssi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@will0684 will0684 merged commit d9962fb into main Aug 2, 2021
@shawn320 shawn320 deleted the upgrade-next branch November 9, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants